Debug step tenon/mortise viz #328
Conversation
This is actually normal that you are getting this result, because your step depth is out of proportion. In the picture below you can see that after a certain depth your step is going outside the beam. (with red you can see the main_beam blank). You would see a similar issue in the BTL viewer as well because the step goes out of the beam, but you will not get any errors. What we can do is set a limit to the depth so that is proportional to the strut_inclination. But anyway, imo the user needs to also be aware of what is considered a sensible parameter for a specific feature and what not.
|
|
@papachap as we discussed
|
Bug fix for the visualization of the tenon and mortise in the StepJoint and StepJointNotch.
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas_timber.datastructures.Beam.