Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting .plist file to .yaml does not properly quote numeric values defined as a string #7

Open
apizz opened this issue Mar 2, 2021 · 3 comments

Comments

@apizz
Copy link

apizz commented Mar 2, 2021

Would require #5.

Currently, numeric values aren't quoted when the XML defines the value as a string

Example excerpt:

<key>MinimumVersion</key>
<string>1.0.0</string>

Example result:

MinimumVersion: 1.0.0

I would expect this to be converted to:

MinimumVersion: '1.0.0'

or

MinimumVersion: "1.0.0"
@smithjw
Copy link

smithjw commented Apr 22, 2021

@grahampugh I've also seen this and found that the Autopkg recipes will not run unless they're quoted

@grahampugh
Copy link
Owner

Weird, I haven't seen that issue, but please remember that all YAML-based recipes should be minimum version of "2.3" (which should get quoted automatically).

@grahampugh grahampugh reopened this Apr 22, 2021
@smithjw
Copy link

smithjw commented Apr 22, 2021

Ahhh, that must be it. The recipes were older versions when converted initially. Then I modified the to min version to 2.3 when I started tweaking things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants