Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is MediaPlaylist.Segments a ring buffer instead of a normal slice? #127

Open
eric opened this issue Mar 29, 2019 · 0 comments
Open

Why is MediaPlaylist.Segments a ring buffer instead of a normal slice? #127

eric opened this issue Mar 29, 2019 · 0 comments

Comments

@eric
Copy link
Contributor

eric commented Mar 29, 2019

I've been trying to reason out why the usage of MediaPlaylist.Segments is why it is and I have trouble coming up with good reasoning.

It seems that head and tail are used internally but not exposed anywhere publicly, so it is impossible to get a MediaPlaylist.Segments that matches the internal state.

It doesn't make sense to me why we can't just have MediaPlaylist.Segments be a strait forward slice where the capacity always maps to what is really defined.

Does anyone have any insight for why it is implemented this way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant