docs: review readme #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szkiba
reviewed
Jun 16, 2023
README.md
Outdated
| @@ -273,7 +273,7 @@ Flags: | |||
| Use "k6 dashboard [command] --help" for more information about a command. | |||
| ``` | |||
|
|
|||
| At the moment, the `dashboard` command has only one subcommand, `replay`, which can be used to play back test run results previously saved in JSON format for the dashboard. | |||
| At the moment, the `dashboard` command has only one subcommand, `replay`, which can be used to play back test run results previously saved in JSON format from the dashboard. | |||
There was a problem hiding this comment.
actually it is not saved from the dshboard, but from k6's json output. The 'for' here maybe wrong, maybe the sentence should and with 'format' word?
There was a problem hiding this comment.
Ah, I see. Sorry about that. How about "... saved in JSON format from k6." Is that correct?
|
Hi @craigpastro , thank you. I had just a little corcection comment... |
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=======================================
Coverage 83.77% 83.77%
=======================================
Files 11 11
Lines 456 456
=======================================
Hits 382 382
Misses 57 57
Partials 17 17 |
|
Hi @craigpastro , thank you, I just merged. |
|
Thank you, @szkiba ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @szkiba 👋
Sorry it took me so long, but I gave a once-over to the readme here. It's not much but please let me know what you think.
Thanks!