Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structuring the timings tab #55

Closed
oleiade opened this issue Aug 28, 2023 · 1 comment · Fixed by #71
Closed

Structuring the timings tab #55

oleiade opened this issue Aug 28, 2023 · 1 comment · Fixed by #71
Labels
enhancement New feature or request

Comments

@oleiade
Copy link
Member

oleiade commented Aug 28, 2023

We discussed this internally, too: the timings tab at the moment contains only HTTP information.

Screenshot 2023-08-28 at 16 41 57

My understanding is that we intend to support more metrics eventually (grpc, websockets, etc). If that's the case, I would suggest already putting the existing (HTTP) charts under a foldable HTTP subsection (in the same fashion as possible within a Grafana dashboard).

Otherwise, if we intend to keep only HTTP-related charts there, I suggest renaming the tab.

What do you think?

@oleiade oleiade added the enhancement New feature or request label Aug 28, 2023
@szkiba
Copy link
Collaborator

szkiba commented Aug 28, 2023

Sure, as we discussed there will be a foldable sections on tabs. It is on my list :)

@szkiba szkiba pinned this issue Sep 11, 2023
@szkiba szkiba linked a pull request Oct 3, 2023 that will close this issue
@szkiba szkiba closed this as completed in #71 Oct 3, 2023
@oleiade oleiade unpinned this issue Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants