From 47ac4c060bd958d788a646d5f272765f2ebc2867 Mon Sep 17 00:00:00 2001
From: ankur22 <ankur.agarwal@grafana.com>
Date: Fri, 4 Oct 2024 16:56:39 +0100
Subject: [PATCH] Update test to work with dblClick

The test now doesn't test with combo keys which doesn't work yet.
Instead we're using dblClick.
---
 tests/keyboard_test.go | 108 ++++++++++++++++++++++++-----------------
 1 file changed, 64 insertions(+), 44 deletions(-)

diff --git a/tests/keyboard_test.go b/tests/keyboard_test.go
index dc056b09b..f8a4dd520 100644
--- a/tests/keyboard_test.go
+++ b/tests/keyboard_test.go
@@ -1,14 +1,16 @@
 package tests
 
 import (
+	"context"
 	_ "embed"
 	"runtime"
-	"strings"
 	"testing"
+	"time"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
+	"github.com/grafana/xk6-browser/common"
 	"github.com/grafana/xk6-browser/keyboardlayout"
 )
 
@@ -83,54 +85,72 @@ func TestKeyboardPress(t *testing.T) {
 	})
 
 	t.Run("control_or_meta", func(t *testing.T) {
-		t.Skip("FIXME") // See https://github.com/grafana/xk6-browser/issues/424
 		t.Parallel()
 
-		tb := newTestBrowser(t)
+		tb := newTestBrowser(t, withFileServer())
 		p := tb.NewPage(nil)
-		kb := p.GetKeyboard()
-
-		err := p.SetContent(`<input>`, nil)
-		require.NoError(t, err)
-		el, err := p.Query("input")
-		require.NoError(t, err)
-		require.NoError(t, p.Focus("input", nil))
 
-		inputVal := "abc"
-
-		// Type abc in input field
-		ss := strings.Split(inputVal, "")
-		for _, c := range ss {
-			require.NoError(t, kb.Press(c, nil))
+		// Navigate to page1
+		url := tb.staticURL("page1.html")
+		opts := &common.FrameGotoOptions{
+			Timeout: common.DefaultTimeout,
 		}
-
-		v, err := el.InputValue(nil)
-		require.NoError(t, err)
-		require.Equal(t, inputVal, v)
-
-		// Select the content of the input field
-		require.NoError(t, kb.Down("Shift"))
-		for i := 0; i < len(inputVal); i++ {
-			require.NoError(t, kb.Press("ArrowLeft", nil))
-		}
-		// Should release the key but the selection should remain active.
-		require.NoError(t, kb.Up("Shift"))
-
-		// "Cut" operation.
-		require.NoError(t, kb.Press("ControlOrMeta+x", nil))
-
-		// Input field should be empty after "cut" operation.
-		v, err = el.InputValue(nil)
-		require.NoError(t, err)
-		require.Equal(t, "", v)
-
-		// "Paste" operation.
-		require.NoError(t, kb.Press("ControlOrMeta+v", nil))
-
-		// Input field should contain abc again after "paste" operation.
-		v, err = el.InputValue(nil)
-		require.NoError(t, err)
-		require.Equal(t, inputVal, v)
+		_, err := p.Goto(
+			url,
+			opts,
+		)
+		assert.NoError(t, err)
+
+		// Make sure the h1 header is "Page 1"
+		text, err := p.Locator("h1", nil).InnerText(nil)
+		assert.NoError(t, err)
+		assert.Equal(t, "Page 1", text)
+
+		ctx, cancel := context.WithTimeout(tb.context(), 5*time.Second)
+		defer cancel()
+
+		bc := tb.Browser.Context()
+		var newTab *common.Page
+
+		// We want to meta/control click the link so that it opens in a new tab.
+		// At the same time we will wait for a new page creation with WaitForEvent.
+		err = tb.run(ctx,
+			func() error {
+				var resp any
+				resp, err := bc.WaitForEvent("page", nil, 5*time.Second)
+				if err != nil {
+					return err
+				}
+
+				var ok bool
+				newTab, ok = resp.(*common.Page)
+				assert.True(t, ok)
+
+				return nil
+			},
+			func() error {
+				kb := p.GetKeyboard()
+				assert.NoError(t, kb.Down("ControlOrMeta"))
+				err = p.Locator(`a[href="page2.html"]`, nil).Click(common.NewFrameClickOptions(p.Timeout()))
+				assert.NoError(t, err)
+				assert.NoError(t, kb.Up("ControlOrMeta"))
+
+				return nil
+			},
+		)
+		assert.NoError(t, err)
+
+		// Wait for the new tab to complete loading.
+		assert.NoError(t, newTab.WaitForLoadState("load", nil))
+
+		// Make sure the newTab has a different h1 heading.
+		text, err = newTab.Locator("h1", nil).InnerText(nil)
+		assert.NoError(t, err)
+		assert.Equal(t, "Page 2", text)
+
+		// Make sure there are two pages open.
+		pp := bc.Pages()
+		assert.Len(t, pp, 2)
 	})
 
 	t.Run("meta", func(t *testing.T) {