You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
> I can't think of any gotchas on this. I like the abstraction... the only "hard part" is remembering to add the alias here when someone else (devs) make structural changes. In the current process, it's a little more in front of them with the aliases metadata (although, I don't think many really understand how it works in the current implementation).
tl;dr LGTM
Yeah that's a fair concern. We could write a little script that checks that: if there are renamed files, that there are also changes to the rewrites file. We could even post that as a comment on the PR or file.
Yeah that's a fair concern. We could write a little script that checks that: if there are renamed files, that there are also changes to the rewrites file. We could even post that as a comment on the PR or file.
Originally posted by @jdbaldry in #571 (comment)
The text was updated successfully, but these errors were encountered: