Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script that notifies if a file is renamed but there is no update to the rewrites file #579

Open
jdbaldry opened this issue Mar 11, 2024 · 0 comments

Comments

@jdbaldry
Copy link
Member

          > I can't think of any gotchas on this. I like the abstraction... the only "hard part" is remembering to add the alias here when someone else (devs) make structural changes. In the current process, it's a little more in front of them with the aliases metadata (although, I don't think many really understand how it works in the current implementation).

tl;dr LGTM

Yeah that's a fair concern. We could write a little script that checks that: if there are renamed files, that there are also changes to the rewrites file. We could even post that as a comment on the PR or file.

Originally posted by @jdbaldry in #571 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant