Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support __text/__value custom display query variables #275

Closed
njvrzm opened this issue May 1, 2024 · 5 comments
Closed

Support __text/__value custom display query variables #275

njvrzm opened this issue May 1, 2024 · 5 comments

Comments

@njvrzm
Copy link
Contributor

njvrzm commented May 1, 2024

Is your feature request related to a problem? Please describe.
Users migrating from the PostgreSQL datasource to the redshift datasource lose the ability to create query variables with custom display values using __value and __text columns as described in the documentation.

See this community thread for an example.

Describe the solution you'd like
Redshift should support this feature to ease migration.

@StephenKing
Copy link
Contributor

Thanks @njvrzm for filing the issue in my name.

If someone can give me a pointer, how this functionality can be added, I can try to file a PR.

Without this, dashboards variables are significantly less comfortable (users now have to enter the customer ID to filter for, instead of previously the ability to select based on the name of the customer) from a query variable.

@katebrenner katebrenner moved this from Incoming to Backlog in AWS Datasources May 3, 2024
@sarahzinger
Copy link
Member

relates to grafana/athena-datasource#286

@StephenKing
Copy link
Contributor

Indeed, using text and value instead of __text and __value works.

@sarahzinger
Copy link
Member

Just a heads up this is still broken, see discussion here: grafana/athena-datasource#286

@idastambuk
Copy link
Contributor

The use of text and value variables was misleading in the Grafana docs. We have updated the Redshift docs recently - tldr this is supported with text and value variables instead of __text and __value.

@github-project-automation github-project-automation bot moved this from Backlog to Done in AWS Datasources Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants