Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add topologySpreadConstraint (#3538) #3539

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

joke
Copy link
Contributor

@joke joke commented Sep 4, 2024

basic support for topologySpreadConstraint

@joke joke requested a review from a team as a code owner September 4, 2024 13:08
@CLAassistant
Copy link

CLAassistant commented Sep 4, 2024

CLA assistant check
All committers have signed the CLA.

@aleks-p
Copy link
Contributor

aleks-p commented Sep 6, 2024

Hey @joke, thanks for your contribution! It looks like you need to run make helm/docs before this can be merged.

Via https://github.com/grafana/pyroscope/actions/runs/10742066442/job/29798271147?pr=3539

Documentation not up to date. Please run helm-docs and commit changes!

@joke
Copy link
Contributor Author

joke commented Sep 7, 2024

Hey @joke, thanks for your contribution! It looks like you need to run make helm/docs before this can be merged.

Via https://github.com/grafana/pyroscope/actions/runs/10742066442/job/29798271147?pr=3539

Documentation not up to date. Please run helm-docs and commit changes!

done

@aleks-p
Copy link
Contributor

aleks-p commented Sep 10, 2024

It looks like we are all set, feel free to merge it at any time!

@joke
Copy link
Contributor Author

joke commented Sep 11, 2024

It looks like we are all set, feel free to merge it at any time!

I don't have permission to do that 😁

@aleks-p aleks-p merged commit 2e677cc into grafana:main Sep 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants