Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant bundles building #66

Open
rozetko opened this issue Jan 31, 2019 · 1 comment · May be fixed by #70
Open

Redundant bundles building #66

rozetko opened this issue Jan 31, 2019 · 1 comment · May be fixed by #70

Comments

@rozetko
Copy link
Contributor

rozetko commented Jan 31, 2019

We should make webpack config more exact
For example, components/device_list is imported here:

kentik-app/src/module.ts

Line 5 in fd9db41

import { DeviceListCtrl } from './components/device_list';

But it also gets built separately by webpack: https://github.com/grafana/kentik-app/blob/master/build/webpack.base.conf.js#L25
@rozetko rozetko changed the title Wrong webpack config Redundant entries in Webpack config Jan 31, 2019
@rozetko rozetko changed the title Redundant entries in Webpack config Redundant bundles building Jan 31, 2019
@jonyrock
Copy link

jonyrock commented Feb 4, 2019

Also there is no need to build dist/config/module.js because it is should be exported in dist/module.ts

@sankerust sankerust linked a pull request Feb 4, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Redundant bundles building #66
2 participants
@jonyrock @rozetko