Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

GitHub bot for handling PRs #388

Open
alexanderzobnin opened this issue Mar 1, 2019 · 1 comment
Open

GitHub bot for handling PRs #388

alexanderzobnin opened this issue Mar 1, 2019 · 1 comment

Comments

@alexanderzobnin
Copy link
Contributor

Recently I added more checks into CircleCI configuration. It's really helpful and let you know if something wrong in the pushed plugin. But if it fails, you have to go to the CircleCI and look into the logs. The same thing with warnings. There's no possibility to show warnings with CircleCI - the build is only green or red.
Would be much better to have a kind of PR summary posted after all checks are finished. Something like codecov does:

d7e81e4-screen_shot_2017-01-20_at_9 40 15_am

It's possible via GitHub API, but in this case, you have to write your script and add it into CircleCI config. The problem is a github token. In order to allow script to publish a comment, you have to pass api token into the script. It may be done with CircleCI env variables, but if you want to run this script for the external PRs you need to allow passing env variables to external PRs. It's not a secure way, because external user can change a circleci config and get access to github token.

So the good alternative is to build our own github bot (with probot, for instance). Bot is listening for webhooks and can run checks and post PR summary. Another benefit from this approach - we automate issue triage and add some labels like new plugin, update, and, for example, priority based on plugin popularity.

It's related to #332 as well.

@Efrat19
Copy link

Efrat19 commented Oct 6, 2019

sorry for the interrupt, this one isnt labeled as help-wanted
but it sounds fun anyway...
may i take a shot?
inorder to help, i must get a wider characterising about this app-
what is the scope in which this project should be created?
what do you want this bot to do on each event and how?
reply if my help is needed 😉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants