Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra empty blue banner is showing for SceneViewer with matterport scene #274

Closed
sheilaXu opened this issue Feb 20, 2024 · 7 comments
Closed
Labels

Comments

@sheilaXu
Copy link
Contributor

What happened:
When loading a matterport scene in Grafana v10, there will be an extra empty blue banner showing up that is not interact-able. The same scene will not have the blue banner when using Grafana v9, and non-matterport scene is not having the blue banner in v10

Screenshot 2024-02-15 at 5 31 31 PM

What you expected to happen:
There should be no blue banner.

How to reproduce it (as minimally and precisely as possible):
With Grafana v10, load a matterport scene in SceneViewer panel

Anything else we need to know?:
From console log, there is a failed matterport API call. But since the scene is loading fine, if it's causing the blue banner, then we want to remove it for this case.

Environment:

  • Grafana version: 10.2.3
  • Plugin version: 1.11.0
@sarahzinger
Copy link
Member

Reaching out to the TwinMaker team at AWS to see their thoughts on this

@torkelo
Copy link
Member

torkelo commented Feb 21, 2024

@sheilaXu is this on Grafana Cloud? Looks like the cloud trial / licence banner

What is SceneViewer?

@sarahzinger
Copy link
Member

SceneViewer is a panel visualization that comes installed with the twinmaker datasource/app.

@sarahzinger sarahzinger self-assigned this Feb 21, 2024
@sarahzinger
Copy link
Member

sarahzinger commented Feb 21, 2024

I'm a bit stumped but my current hunch is that there is some kind of global style change in grafana that is causing unexpected style changes in Twinmaker's Scene Viewer Panel.

The Blue Bar itself is coming from within the matterport-viewer webcomponent which I don't believe grafana has any direct control over:
Image

What's interesting is that this "error-bar" component exists in the dom in earlier versions of grafana as well it's just getting covered by the panel title or something?
Image

Is it possible for the Twin Maker team to edit the css in the Matterport Web component?

@sarahzinger sarahzinger removed their assignment Feb 21, 2024
@mitchlee-amzn
Copy link

This blue bar is coming from Matterport, the likely fix is to upgrade the Matterport SDK Version, update the IotAppKit version in the Grafana Plugin, and see. Otherwise, I can reach out to our contacts at Matterport to get some next steps.

@taleena
Copy link
Collaborator

taleena commented Jul 30, 2024

Update that TM team may have a fix in for this and is awaiting testing feedback from customer, then we can close this out.

@taleena
Copy link
Collaborator

taleena commented Aug 13, 2024

TM team mentioned we can close this out, customer verified. Thank you!

@taleena taleena closed this as completed Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

5 participants