-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include "Approved" flag in Pull Requests #70
Comments
Hey @kminehart I don't think there is a "Approved" flag in the Pull Request object. Maybe we could add a similar feature using the review state? |
That seems to be what Github staff is suggesting:
|
interesting. That shouldn't be too hard. But probably not easy enough to be a "good first issue" :P I'll take a look this weekend. |
I don't know guys, there are ways to configure how many approvals are required for merge, or if new commits needs a new approval for merge:
also:
Approval count is a good info, though! |
Good point 🤔 I agree we probably shouldn't make any assumptions and should just return counts, maybe a count for each of the possible approval states, since you'd possibly would query all of them anyway? |
No description provided.
The text was updated successfully, but these errors were encountered: