Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include "Approved" flag in Pull Requests #70

Open
kminehart opened this issue Sep 15, 2020 · 5 comments · May be fixed by #402
Open

Include "Approved" flag in Pull Requests #70

kminehart opened this issue Sep 15, 2020 · 5 comments · May be fixed by #402
Labels
type/feature-request Requested new feature or enhancement

Comments

@kminehart
Copy link
Contributor

No description provided.

@kminehart kminehart added type/feature-request Requested new feature or enhancement good first issue labels Sep 15, 2020
@kminehart kminehart added this to the v1.0.6 milestone Sep 15, 2020
@vschettino
Copy link
Contributor

Hey @kminehart I don't think there is a "Approved" flag in the Pull Request object. Maybe we could add a similar feature using the review state?

@maximbaz
Copy link

That seems to be what Github staff is suggesting:

A pull request is approved when there is one or more reviews with an APPROVED state. So you would use the reviews connection, filter by APPROVED, and check if the totalCount is greater than 0.

@kminehart
Copy link
Contributor Author

interesting. That shouldn't be too hard. But probably not easy enough to be a "good first issue" :P

I'll take a look this weekend.

@vschettino
Copy link
Contributor

I don't know guys, there are ways to configure how many approvals are required for merge, or if new commits needs a new approval for merge:

In the Required approving reviews drop-down menu, select the number of approving reviews you'd like to require on the branch.

also:

Optionally, select Dismiss stale pull request approvals when new commits are pushed. This dismisses a pull request approval review when a code-modifying commit is pushed to the branch.

Approval count is a good info, though!

@maximbaz
Copy link

Good point 🤔 I agree we probably shouldn't make any assumptions and should just return counts, maybe a count for each of the possible approval states, since you'd possibly would query all of them anyway?

@jhunthrop jhunthrop removed this from the v1.0.6 milestone Apr 16, 2021
@gwdawson gwdawson moved this to Backlog in OSS Big Tent Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request Requested new feature or enhancement
Projects
Status: Backlog
4 participants