Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FillChar called with incorrect parameters #126

Open
deanm73 opened this issue Jun 8, 2023 · 1 comment
Open

FillChar called with incorrect parameters #126

deanm73 opened this issue Jun 8, 2023 · 1 comment

Comments

@deanm73
Copy link

deanm73 commented Jun 8, 2023

src/corelib/x11/fpg_x11.pas
line 1261: FillChar(ErrText,0, SizeOf(ErrText));
src/corelib/fpg_widget.pas
line 201: FillChar(p^.Params, 0, SizeOf(p^.Params));
line 235: FillChar(m.Params, 0, SizeOf(m.Params));

In all of the above cases 2nd and 3rd parameters have been swapped - size should be 2nd and value 3rd.

@rchastain
Copy link

Thank you for reporting.

By the way, the file for cases 2 and 3 is fpg_msgqueue.inc.

I created a branch in my fork for that issue and made a PR.

As I am not sure to have done it correctly, here is what I did:

git checkout -b fillchar_param

and after doing the modifications:

git add .
git commit -m "FillChar parameters order"
git push --set-upstream origin fillchar_param

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants