Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion to change USB/LSB step size #920

Open
pe1chl opened this issue Dec 27, 2020 · 4 comments · May be fixed by #1168
Open

Suggestion to change USB/LSB step size #920

pe1chl opened this issue Dec 27, 2020 · 4 comments · May be fixed by #1168
Labels
feature

Comments

@pe1chl
Copy link

pe1chl commented Dec 27, 2020 •
edited
Loading

I suggest to change the frequency step size for USB and LSB from 100 Hz to 50 Hz.
This makes a noticable improvement when tuning signals for best voice quality.
I make this change every time I download the software, in file src/applications/gqrx/mainwindow.cpp:
case DockRxOpt::MODE_LSB:
...
click_res = 50;

(same for USB)

Of course even better would be to have some setup of custom step size per mode in the user interface but that would involve more work.
@argilo argilo added the feature label Dec 28, 2020
ulrichloose added a commit to ulrichloose/gqrx that referenced this issue Jan 4, 2021
@ulrichloose
User settabel SSB Stepsize
3d70ab7 
for gqrx-sdr#920
@ulrichloose ulrichloose mentioned this issue Jan 4, 2021
Open
ulrichloose added a commit to ulrichloose/gqrx that referenced this issue Jan 11, 2021
@ulrichloose
User settabel SSB Stepsize
109a031 
for gqrx-sdr#920
ulrichloose added a commit to ulrichloose/gqrx that referenced this issue Jan 11, 2021
@ulrichloose
User settabel SSB Stepsize
0e8c478 
for gqrx-sdr#920
ulrichloose added a commit to ulrichloose/gqrx that referenced this issue Jan 11, 2021
@ulrichloose
User settabel SSB Stepsize
7cfbd65 
for gqrx-sdr#920
pinkavaj pushed a commit to pinkavaj/gqrx that referenced this issue Nov 10, 2022
@jiri-pinkava
Set resolution for tunning on SSB demodulator to 50 Hz
8804bb0 
Close gqrx-sdr#920
@pinkavaj pinkavaj linked a pull request Nov 10, 2022 that will close this issue
Open
ulrichloose added a commit to ulrichloose/gqrx that referenced this issue Nov 28, 2022
@ulrichloose
User settabel SSB Stepsize
06aff75 
for gqrx-sdr#920
ulrichloose added a commit to ulrichloose/gqrx that referenced this issue Nov 28, 2022
@ulrichloose
User settabel SSB Stepsize
0d70151 
for gqrx-sdr#920
ulrichloose added a commit to ulrichloose/gqrx that referenced this issue Nov 28, 2022
@ulrichloose
User settabel SSB Stepsize
d60e6f1 
for gqrx-sdr#920
ulrichloose added a commit to ulrichloose/gqrx that referenced this issue Nov 28, 2022
@ulrichloose
User settabel SSB Stepsize
0963007 
for gqrx-sdr#920
ulrichloose added a commit to ulrichloose/gqrx that referenced this issue Nov 29, 2022
@ulrichloose
User settabel SSB Stepsize
3841409 
for gqrx-sdr#920
ulrichloose added a commit to ulrichloose/gqrx that referenced this issue Nov 29, 2022
@ulrichloose
User settabel SSB Stepsize
1e7ef67 
for gqrx-sdr#920
@argilo
Copy link
Member

argilo commented Apr 16, 2023

I had a look back at the commit history to see how the tuning step has evolved. Originally the tuning step was 10 Hz for all modes. Then a72891b (included in version 2.2) implemented per-mode tuning steps:

  • Demod Off - 100 Hz
  • AM - 100 Hz
  • SSB - 10 Hz
  • CW - 10 Hz
  • Narrow FM - 100 Hz
  • WFM - 1000 Hz

And finally, SSB was changed to 100 Hz and Demod off to 1000 Hz in c916933 (included in version 2.4). I'm not sure what motivated the change, but perhaps 10 Hz was too low to allow convenient tuning with the mouse wheel. It also seems there was a preference to use powers of 10, which have the benefit of only changing one frequency digit. (I'm not sure this is important, though.)

Reducing the SSB step to 50 Hz seems like it might be a reasonable choice since it's not too much lower than the long-standing 100 Hz step, but it still allows a tuning error of ±25 Hz which is quite noticeable to my ear. What do you think about going back to the old 10 Hz step?

I'm not convinced that making the tuning step user-configurable is worth the added complexity, so my inclination is to either reduce the tuning step (to 50 or 10 Hz) or leave it untouched.

@vladisslav2011
Copy link
Contributor

Sometimes I want 10Hz SSB tuning step, but more often I want 500Hz SSB tuning step.
I'll make it user-configurable...

@argilo
Copy link
Member

argilo commented Apr 17, 2023

I'll make it user-configurable...

By the way, there is an open pull request for that: #928

As well as one to change the step size to 50 Hz: #1168

@vladisslav2011
Copy link
Contributor

I want to make per-mode tuning step user-configurable, not only SSB.
But I should fix "change 10 files and write 20 methods to add a single checkbox" issue first...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set resolution for tunning on SSB demodulator to 50 Hz pinkavaj/gqrx
3 participants
@argilo @pe1chl @vladisslav2011