-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome 113 with WebGPU breaks GPU.js #820
Comments
Same. |
Nevermind; renamed all "GPU" instances in gpu-browser.min to "GPUX" That worked for now. |
Me to, but thats a very bad practice.... thats a temp solution not a permanent one |
Oh, yes, bad practice indeed. "Dont try this at home" Consider it a workaround until a better solution is implemented. |
@robertleeplummerjr can you fix this? |
Yea I'll have to address it soon. Perhaps next week. |
maybe gpu.js can leverage WebGPU? would be especially interesting to see if it allows more flexibility with data types passed to/returned by gpu.js |
yeah that will be awesome! |
We'd love to do that, but the existing API isn't mature enough across browsers, at least from what I've seen with compute capabilities. I've never had a stock example actually run and have a means of starting to upgrade GPU.js to that. As far as the issue with |
sounds good enough |
Hacky fix to this issue gpujs/gpu.js#820 by renaming all "GPU" instances in gpu-browser.min to "GPUX" by: 1) Adding a local version of gpu-browser.min.js and running replace all 2) Making a change to skeletonization.js line 23 (skeletonization.thinning_gpu = new GPUX();)
Hacky fix to this issue gpujs/gpu.js#820 by renaming all "GPU" instances in gpu-browser.min to "GPUX" by: 1) Adding a local version of gpu-browser.min.js and running replace all 2) Making a change to skeletonization.js line 23 (skeletonization.thinning_gpu = new GPUX();)
We'd love to do that, but the existing API isn't mature enough across browsers, The api is very VERY mature, but only a few browsers support it https://caniuse.com/?search=webgpu |
As I have looked at gpu.js code vs current webgpu surface, it will be largely obsoleted, as gpu.js has to deal with how webgl handles concurrency, there is no such problem in webgpu, so I think its better to totally start from scratch (keep the brand name if you must, but from scratch you must start) |
What is wrong?
Chrome 113 breaks GPU.js when not scoped, its already has GPU object
Where does it happen?
when u try to use
new GPU
How do we replicate the issue?
try using GPU.js
How important is this (1-5)?
5
Expected behavior (i.e. solution)
to work
Other Comments
The text was updated successfully, but these errors were encountered: