Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: System volume decreases during venting #406

Open
1 task done
DustinGrau opened this issue Oct 28, 2024 · 1 comment
Open
1 task done

[Bug]: System volume decreases during venting #406

DustinGrau opened this issue Oct 28, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@DustinGrau
Copy link
Collaborator

What actions were attempted?

Manually trigger a vent sequence or fire a stream long enough to go into overheat.

What actually happened?

This one I noticed myself so logging a bug to make sure I remember to revisit it, but also inform others that it might be occurring. While either manually venting or entering an overheat sequence I noticed the system overall volume being reduced without any interactions on my part. I could see the % change on the web UI so it wasn't just me hallucinating or thinking it was something else. I manually had to turn up the volume after the venting to get it back to normal.

What was expected?

Did not expect volume to randomly change without interaction.

Firmware Version

5.4.2 (technically 6.0 Beta 2)

Mode in Use

Super Hero / Video Game

Notable Hardware

Running all the latest version boards, modified Wasteland smoke kit via relay.

Homework Completed

  • I did my part!
@DustinGrau DustinGrau added the bug Something isn't working label Oct 28, 2024
@DustinGrau DustinGrau self-assigned this Oct 28, 2024
@nomakewan
Copy link
Collaborator

nomakewan commented Oct 29, 2024

Looking into this, there are only two possibilities.

  1. Somehow, the check HERE is going wonky-doodle. This is impossible while firing, but since I do not know how you are initiating your overheat sequences out in the field I cannot discount it. The check will prevent this volume control from working if either of the right-hand switches are in the 'on' position. However, I bring it up because it works by holding down Intensify, and holding down Intensify is what does the manual overheat sequence in Mode Super Hero as well (albeit with the bottom-right switch on and the top-right switch off).

  2. Somehow, the rotary encoder on the Attenuator is going wonky-doodle. There are no guards on the rotary encoder's volume control other than if the wand is currently firing and the current multiplier is greater than 2 (at which point it will function as the stream attenuator rather than the volume control). This can be seen HERE. This means that when firing and the multiplier is 0~2, it will continue to act as a volume control. It will also act as volume control while the ribbon cable alarm is going off, and while overheating, and while venting, and while wand mashing, and..............you get the point.

Personally 2 seems more likely. Perhaps the guards on the volume control need to be made more robust, and the actual functionality of the rotary encoder itself should be inspected to make sure no errant signals are being passed along as turns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants