Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable Brass Plated Proton Stream Animation #350

Open
1 task done
Aces6469 opened this issue Jul 16, 2024 · 6 comments
Open
1 task done

Unstable Brass Plated Proton Stream Animation #350

Aces6469 opened this issue Jul 16, 2024 · 6 comments
Labels
enhancement New feature or request
Milestone

Comments

@Aces6469
Copy link

Aces6469 commented Jul 16, 2024

What would you like to add in terms of software changes?

Possibly update the FE lid off CTS animation to be more chaotic to simulate the brass plated proton pack's trifurcated proton stream. Could even be a toggle for the normal stream animations for those who would want to have a normal colored proton stream with the trifurcation (could be put in as a third option to the new barrel animation setting in the 6.0 EEPROM). Very unlikely to be added since it's super specific and probably a difficult thing to program, but I just thought I'd pitch the idea.

Would this request involve any specific hardware?

I doubt it, but it'd probably look best on the frutto barrel LEDs?

Homework Completed

  • I did my part!
@Aces6469 Aces6469 added the enhancement New feature or request label Jul 16, 2024
@nomakewan
Copy link
Collaborator

It's actually already in planning for v6, because one of the major changes for v6 is rewriting a lot of the LED code to be able to write "sprites" to the LED arrays to improve how the animations look.

Likewise, one of the animations we would like to improve is the brass pack barrel animation. So yeah!

@Aces6469
Copy link
Author

Oh sweet! I presume it'd stay as a CTS only animation/coloring? Or would it move to the base barrel effect with the lid off?

@nomakewan
Copy link
Collaborator

That hasn't been decided just yet, but in my opinion all the "brass pack" stuff should be its own separate mode, and if that is the case, then the "normal" firing for it would indeed be the green shot with the orange lightning.

@Aces6469
Copy link
Author

As someone whose entire pack is the brass plated pack, I completely agree lol.

@Aces6469
Copy link
Author

as a quick side note though, it might be worth tuning the exact colors for the brass stream, the green doesn't come off as the more minty look, and the orange goes more yellow in my experience. Just some food for thought.

@nomakewan
Copy link
Collaborator

If you are basing your opinions on what it currently looks like, rest assured that the current animations are going in the bin and won't be referenced for v6.

We will of course take our respective copies of the bluray and try to get as close to the on-screen representation as the LED array will allow.

@nomakewan nomakewan added this to the v6.0.0 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants