Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

successful_checks is always empty for AVIF #83

Open
leo-barnes opened this issue Sep 12, 2024 · 2 comments
Open

successful_checks is always empty for AVIF #83

leo-barnes opened this issue Sep 12, 2024 · 2 comments

Comments

@leo-barnes
Copy link

Describe the issue
When compiling the latest ComplianceWarden and running it on an AVIF file with JSON output, the "successful_checks" array is always empty.

Detailed analysis
From comparing the avif.cpp rules to the av1_hdr10plus.cpp rules, the latter seem to be using out->covered();. I'm assuming this is the snippet that marks the rule as successfully checked.

This would be required in order to implement AOMediaCodec/av1-avif#219

@leo-barnes
Copy link
Author

Yup, the out->covered(); calls seem to be the issue.

@rbouqueau
Copy link
Member

Indeed. You can add them based on the code (+ the coverage report you can generate with this script).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants