Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to E.164 format #99

Merged
merged 17 commits into from
Sep 13, 2023
Merged

Switch to E.164 format #99

merged 17 commits into from
Sep 13, 2023

Conversation

ybrusentsov
Copy link
Owner

@ybrusentsov ybrusentsov commented Sep 13, 2023 •
edited
Loading

What has been done

  • Switch to E.164 formatted phone value
    • Return e164 phone in onChange callback by default
    • Allow get full phone when using component with disabledDialCodeAndPrefix
  • Refactor user input handling: move logic from hook into separate helper files
  • Small cursor handling updates

@ybrusentsov
fix!: return E164 phone in onChange callback
939275a 
BREAKING CHANGE: phone value is unified to E164 format
@ybrusentsov
refactor: move handlePhoneChange and handleUserInput to separate help…
a23187a 
…er files
@ybrusentsov
chore(storybook): update ui libs components to use e164 phone value
2b7d42e
@ybrusentsov
refactor(usePhoneInput): move shared config for helper functions to s…
d240f7d 
…eparate object
@ybrusentsov
refactor: return e164 phone value from handlePhoneChange
ab6fce7
@ybrusentsov
fix(handlePhoneChange): return current country on partial dial code m…
dbbf20d 
…atch
@ybrusentsov
fix: fix dynamic format mask with disableDialCodeAndPrefix
5cb1e11
@ybrusentsov
chore: move toE164 to separate util function
49203e1
@ybrusentsov
fix: ignore input handling if user typed non digit character
b175b4e
@ybrusentsov
fix: guess initial country when dial code is disabled
c79adc3
@ybrusentsov
refactor(handleUserInput): update forceDialCode edge case handling
37dc733
@ybrusentsov
fix: allow type prefix if input is empty
08e5811
@ybrusentsov
fix(usePhoneInput): fix e164Phone value on setCountry
cec0700
@ybrusentsov
fix(getCursorPosition): update cursor position logic, fix cursor jump…
5256439 
… on disabled dial code values
@ybrusentsov
fix(getCursorPosition): reuse isNumeric utility function
65d8618
@ybrusentsov
fix(PhoneInput): rename formattedValue to displayValue in onChange me…
3479ae5 
…tadata arg
@ybrusentsov
docs: update type for onChange callback
dd46b0f
@vercel
Copy link

vercel bot commented Sep 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-international-phone-docs ✅ Ready (Inspect) Visit Preview Sep 13, 2023 4:40pm
react-international-phone-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 4:40pm

@ybrusentsov ybrusentsov changed the base branch from master to next September 13, 2023 16:40
@ybrusentsov ybrusentsov merged commit c80bb62 into next Sep 13, 2023
@ybrusentsov ybrusentsov deleted the feat/use-e164-format branch September 13, 2023 17:33
@ybrusentsov
Copy link
Owner Author

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ybrusentsov