Skip to content
This repository has been archived by the owner on Sep 27, 2022. It is now read-only.

clear method should probably be an action? #35

Open
HamsterHuey opened this issue Oct 1, 2018 · 0 comments
Open

clear method should probably be an action? #35

HamsterHuey opened this issue Oct 1, 2018 · 0 comments

Comments

@HamsterHuey
Copy link

Thanks for having this repo as a nice example of MobX + React. I was just browsing through the code and noticed that this method should probably be an action unless I'm missing something? Of course, it probably will work just fine unless you have it set to strict mode, but I figured I'd point it out since pretty much all your other methods across the stores are correctly decorated as actions when they mutate state.

Cheers!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant