Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Lighthouse Score #93

Open
Alonski opened this issue Nov 18, 2019 · 7 comments
Open

Increase Lighthouse Score #93

Alonski opened this issue Nov 18, 2019 · 7 comments

Comments

@Alonski
Copy link
Member

Alonski commented Nov 18, 2019

Currently, our Lighthouse score is quite low: 61 in Incognito.

According to this blog post some of the RealWorld examples have a score of 99:
https://www.freecodecamp.org/news/a-realworld-comparison-of-front-end-frameworks-with-benchmarks-2019-update-4be0d3c78075/

We should work to improve our score. I am sure that there are low hanging tasks that we can do to increase this.
image

Here is the full report that I generated:
Lighthouse Report.pdf
@GCheung55
Copy link
Collaborator

@Alonski can you generate a report from another project to use as a comparison/baseline?

@Alonski
Copy link
Member Author

Alonski commented Nov 19, 2019

@GCheung55 It seems that my laptop is quite unperformant 😅
Maybe someone with a better computer can do it?
Do you have a strong computer?

@mansona
Copy link
Collaborator

mansona commented Nov 19, 2019

I did a comparison with the main frameworks and here are my results:

            Median Mode
React Redux 78 78 78 72 78 78 78
Angular 84 88 84 84 86 84 84
Vue Vuex 90 90 91 90 90 90 90
Ember 70 79 77 79 77 77 79

Essentially Vue is the one to aim for but we could make some tweaks and pass Angular if we wanted to 👍

@GCheung55
Copy link
Collaborator

Running the pages via https://web.dev/measure/ might provide more consistent results than our own computers. It'll generate reports we can download too.

@GCheung55
Copy link
Collaborator

GCheung55 commented Dec 3, 2019 •
edited
Loading

Possible changes we can make:

@mansona
Copy link
Collaborator

mansona commented Dec 3, 2019

I guess it's probably worth defining what we mean by "Lighthouse Score" in this context 🤔 I would assume that we're only focusing on Performance (because that's what comparison blogs focus on) but I guess it makes sense to also fix any low hanging fruit on other audits 🤔

Also, I'm not entirely sure how much of an impact any of these things would have. Especially considering that the main things that are blocking high performance are third party resources (external CSS). How do other apps get around this?

@Alonski
Copy link
Member Author

Alonski commented Dec 6, 2019

Maybe we could load the external CSS lazily :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GCheung55 @Alonski @mansona