Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@param comments #78

Open
ryanmdoyle opened this issue Jun 28, 2019 · 2 comments
Open

@param comments #78

ryanmdoyle opened this issue Jun 28, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@ryanmdoyle
Copy link

Expected Behavior

In Node quickstart, there isn't a comment for what the @param {Object} credentials and other @param is doing. As someone who isn't familiar with what that is (it isn't vanilla node) it took me a while to find that it looks like it's from JSDoc. I don't have experience with a language like C which seems to have similar syntax so I had no idea what that was doing initially. (If anything)

Actual Behavior

It would be great to have an added comment line clarifying these lines of code for those trying to understand the codebase. Something like:

/**
 * Create an OAuth2 client with the given credentials, and then execute the
 * given callback function.
 * @param is a JSDoc tag that provides information about a callback function
 * @param {Object} credentials The authorization client credentials.
 * @param {function} callback The callback to call with the authorized client.
 */

Specifications

  • Node version 10.15.1
  • OS Mac
@sqrrrl sqrrrl added the enhancement New feature or request label Jun 28, 2019
@ryanmdoyle
Copy link
Author

@sqrrrl I'm new to the contributions in gsuitedevs, but I'd love to help tackle this with a PR if I'm able?

@grant
Copy link
Contributor

grant commented Jul 5, 2019

@ryanmdoyle, want to suggest a change?

The object is in the form of the credentials you download from the quickstart site. Maybe we could clarify that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants