Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled node type Super #400

Closed
bb33bb opened this issue Jun 1, 2023 · 3 comments
Closed

Unhandled node type Super #400

bb33bb opened this issue Jun 1, 2023 · 3 comments

Comments

@bb33bb
Copy link

bb33bb commented Jun 1, 2023

node parser.js ../../Protobuf/ast.proto code.js output.ast.proto

content of code.js is
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// Flags: --allow-natives-syntax --no-use-ic --super-ic

class A {
bar() { }
}
class B extends A {
foo() {
return super.bar();
}
}
%PrepareFunctionForOptimization(B.prototype.foo);
new B().foo();
%OptimizeFunctionOnNextCall(B.prototype.foo);
new B().foo();

@saelo
Copy link
Collaborator

saelo commented Jun 19, 2023

Thanks, yes, these are not yet supported by our compiler, but we're happy to take PRs! See #399 (comment) for some general guidance on how to extend the compiler, and don't hesitate to ask for more specific guidance!

@bb33bb bb33bb closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2024
@nth10sd
Copy link

nth10sd commented Jul 30, 2024

@saelo With the current work on the compiler, does this warrant a reopening? Or a new issue?

@saelo
Copy link
Collaborator

saelo commented Jul 31, 2024

As the compiler isn't feature complete, there's probably not too much value in having individual issues open for every feature that's not supported. Instead, the focus should be on whatever feature is currently blocking the most testcases from being compilable, which can be determined by the script linked in issue #437.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants