Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many of the tests are brittle when adding new features to the SimHash #10

Open
thomasdullien opened this issue Oct 1, 2018 · 1 comment
Open

Many of the tests are brittle when adding new features to the SimHash #10

thomasdullien opened this issue Oct 1, 2018 · 1 comment

Comments

@thomasdullien
Copy link
Contributor

This was a desired feature initially to make sure the underlying disassembly is good,
but makes tweaking / improving / adding new features difficult without breaking the
tests.

Particular culprits (and currently broken) are:
flowgraphwithinstructions.creategraph
flowgraphwithinstructions.parsejson
functionsimhash.zero_weight_for_mnemonics

It would be great if we could come up with a way that does not break quite so easily ...
@thomasdullien
Copy link
Contributor Author

At least the first two may be doable by switching to a string comparison on the JSON serialized form?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomasdullien