Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game link redirection for signed-out user #37

Open
tomatocat opened this issue Jul 17, 2020 · 4 comments
Open

Game link redirection for signed-out user #37

tomatocat opened this issue Jul 17, 2020 · 4 comments
Assignees
Labels
priority: medium type: bug Something isn't working

Comments

@tomatocat
Copy link
Collaborator

Describe the bug
When a user is signed out and they try to directly access a game link, they are redirected to the home page with no warning.

Expected behavior
Somewhere in the redirection process, the user should be able to see a message telling them that they are being redirected because they must sign in to view game pages.

@tomatocat tomatocat added the type: bug Something isn't working label Jul 17, 2020
@pl98
Copy link
Collaborator

pl98 commented Jul 17, 2020

This may need further discussion. This behavior currently exists because we want the user to be smoothly redirected after clicking the sign out button. Is showing a warning every time a user signs out going to be problematic in terms of user experience?

@tomatocat
Copy link
Collaborator Author

Yes, there should somehow be a difference between clicking the sign-out button vs. straight up trying to visit the game page while not logged in

@pl98
Copy link
Collaborator

pl98 commented Jul 17, 2020

I have a feeling this might be a little difficult to implement based on how Firebase Auth works with the sign out process. This doesn't seem like a super high priority to me so I'll take a look at this some time next week.

@tomatocat
Copy link
Collaborator Author

yup, feel free to add priority tags to the issue. I didn't add the "final presentation" milestone because I think it's not 100% necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants