This repository has been archived by the owner on Oct 29, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
Scrub binary files from git history #162
Open
jiridanek
wants to merge
580
commits into
googlegenomics:master
Choose a base branch
from
jiridanek:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharded BAM reader and a sample read counting pipeline
Its now in the codelabs repository.
--machineType does not have a default of n1-standard-4 in all contexts.
Now that we are doing client-side filtering for strict shard boundaries, we need to ensure that we are requesting the field that the filter will check.
Allow start/end when reading from the API in CountReads, improve script documentation.
Add Genomics API counters for Dataflow UI display.
…tation Implement sample variant annotation dataflow pipeline
Bump utils-java version.
Adding a more comprehensive test for ReadConverter Added gat-tools-java as a dependency to access the Read->SAMRecord converter
Fixing a few bugs in ReadConverter and adding a new test for Sam -> Read -> Sam conversion.
Update to latest version of DataflowSDK.
Also add validation to --output which fixes googlegenomics#31
Bump utils-java.
Implement fallback CoderProvider.
Merge VerifyBamId to master.
Proto2Coder is preferred because it is deterministic.
Switch VerifyBamId to v1 Position objects.
Also default to use gRPC for VariantSimilarity.
Refactor auth.
Also remove obsolete version of JoinNonVariantSegmentsWithVariants.
Refactor options.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
@jirkadanek Thanks so much for these detailed instructions!!! We will make it so. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: Receiving objects: 100% (6743/6743), 121.52 MiB | 210.00 KiB/s, done.
After: Receiving objects: 100% (6421/6421), 36.37 MiB | 210.00 KiB/s, done.
This change has to be force-pushed. Merging does not do the trick. I am including the exact commands I executed to do this. It might be best if you just run the commands yourself.
Fixes #101
List all files ever in the repository
List all deleted files ever in the repository
Get changelog
Decide what to scrub
Scrub the files from history
Wait for this to complete. It takes a very long time, which proves that scrubbing the files one by one was a bad idea.
Review and push the result
Local clones
Do steps # 8 and # 9 from https://help.github.com/articles/remove-sensitive-data/ on each local clone you have