Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default axis value names need to match Google specs #348

Open
tphinney opened this issue Aug 8, 2024 · 1 comment
Open

Default axis value names need to match Google specs #348

tphinney opened this issue Aug 8, 2024 · 1 comment
Assignees
Labels
FontBakery Fail or Error from FontBakery tests next build

Comments

@tphinney
Copy link
Collaborator

tphinney commented Aug 8, 2024

Change names of defaults for axes as follows:

YOPQ: Regular > Normal
slnt: Regular > Default
slnt: Oblique > ? (NOT Default! Not sure we can support Slanted instances among the default instances?)
wdth: Regular > Normal

Validate STAT particle names and values match the fallback names in GFAxisRegistry.
Check ID: FontBakeryCheck:com.google.fonts/check/STAT/gf_axisregistry
Check that particle names and values on STAT table match the fallback names in each axis entry at the Google Fonts Axis Registry, available at https://github.com/google/fonts/tree/main/axisregistry

Original proposal: fonttools/fontbakery#3022
🔥 ScienceGothic[YOPQ,slnt,wdth,wght].ttf
🔥 FAIL
On the font variation axis 'YOPQ', the name 'Regular' is not among the expected ones (Normal) according to the Google Fonts Axis Registry.

[code: invalid-name]
🔥 FAIL
On the font variation axis 'slnt', the name 'Oblique' is not among the expected ones (Default) according to the Google Fonts Axis Registry.

[code: invalid-name]
🔥 FAIL
On the font variation axis 'slnt', the name 'Regular' is not among the expected ones (Default) according to the Google Fonts Axis Registry.

[code: invalid-name]
🔥 FAIL
On the font variation axis 'wdth', the name 'Regular' is not among the expected ones (SuperCondensed, UltraCondensed, ExtraCondensed, Condensed, SemiCondensed, Normal, SemiExpanded, Expanded, ExtraExpanded, UltraExpanded) according to the Google Fonts Axis Registry.

[code: invalid-name]

@tphinney tphinney added the FontBakery Fail or Error from FontBakery tests label Aug 8, 2024
@tphinney tphinney self-assigned this Aug 8, 2024
kateliev added a commit that referenced this issue Aug 20, 2024
Changed
- YOPQ: Regular to (Normal)
- slnt: Regular to (Default)
- wdth: Regular to (Normal)
- wgth: Regular stays (Regular)
@kateliev
Copy link
Member

Changed!.. but slnt: Oblique > ? (NOT Default! Not sure we can support Slanted instances among the default instances?) will keep it as it is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FontBakery Fail or Error from FontBakery tests next build
Projects
Status: Done but not built
Development

No branches or pull requests

2 participants