Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure soft_dotted characters lose their dot when combined with marks that replace it #326

Open
tphinney opened this issue Jan 4, 2024 · 2 comments
Assignees
Labels
bug Something isn't working FontBakery Fail or Error from FontBakery tests next build

Comments

@tphinney
Copy link
Collaborator

tphinney commented Jan 4, 2024

Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
Check ID: com.google.fonts/check/soft_dotted
An accent placed on characters with a "soft dot", like i or j, causes the dot to disappear. An explicit dot above can be added where required. See "Diacritics on i and j" in Section 7.1, "Latin" in The Unicode Standard.

Characters with the Soft_Dotted property are listed in https://www.unicode.org/Public/UCD/latest/ucd/PropList.txt

See also: https://googlefonts.github.io/gf-guide/diacritics.html#soft-dotted-glyphs

⚠️ ScienceGothic[YOPQ,slnt,wdth,wght].ttf
⚠️ WARN
The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ i̋ j̀ j́ j̃ j̄ j̈ j̑ į̀ į́ į̂ į̃ į̄ į̌ і́ ị̀ ị́ ị̂ ị̃ ị̄

The dot of soft dotted characters should disappear in other cases, for example: i̇ ǐ i̒ i̛̇ i̛̊ i̛̋ ǐ̛ i̛̒ i̤̇ i̤̊ i̤̋ ǐ̤ i̤̒ i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ i̧̇ i̧̊

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Igbo (Latn, 27,823,640 speakers), Dutch (Latn, 31,709,104 speakers), Navajo (Latn, 166,319 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ebira (Latn, 2,200,000 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Gulay (Latn, 250,478 speakers), Mango (Latn, 77,000 speakers), Sar (Latn, 500,000 speakers), Ma’di (Latn, 584,000 speakers), Lugbara (Latn, 2,200,000 speakers), Avokaya (Latn, 100,000 speakers), Kom (Latn, 360,685 speakers), Aghem (Latn, 38,843 speakers), Basaa (Latn, 332,940 speakers), Koonzime (Latn, 40,000 speakers), Nateni (Latn, 100,000 speakers), Dan (Latn, 1,099,244 speakers), Ejagham (Latn, 120,000 speakers). [code: soft-dotted]

@tphinney tphinney added bug Something isn't working FontBakery Fail or Error from FontBakery tests labels Jan 4, 2024
@tphinney tphinney self-assigned this Jan 4, 2024
@tphinney tphinney moved this to To do in Science Gothic VF Jun 10, 2024
@kateliev
Copy link
Member

kateliev commented Aug 7, 2024

Test String: i̊ i̋ j̀ j́ j̃ j̄ j̈ j̑ į̀ į́ į̂ į̃ į̄ į̌ і́ ị̀ ị́ ị̂ ị̃ ị̄ i̇ ǐ i̒ i̛̇ i̛̊ i̛̋ ǐ̛ i̛̒ i̤̇ i̤̊ i̤̋ ǐ̤ i̤̒ i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ i̧̇ i̧̊

kateliev added a commit that referenced this issue Aug 7, 2024
…d with marks that replace it

Added necessary code to features as required by Google

Issue #309: Combining dieresis is misnamed in uni1E85.sc recipe?
Small bug fix in OT features
@kateliev
Copy link
Member

kateliev commented Aug 7, 2024

@tphinney this is now done according to Google standards. Will be in our next build :)

@tphinney tphinney moved this from In progress to Done but not built in Science Gothic VF Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FontBakery Fail or Error from FontBakery tests next build
Projects
Status: Done but not built
Development

No branches or pull requests

2 participants