Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small cap spacing: could be looser in some :CndEtc masters? #181

Open
tphinney opened this issue Oct 31, 2019 · 5 comments
Open

small cap spacing: could be looser in some :CndEtc masters? #181

tphinney opened this issue Oct 31, 2019 · 5 comments
Assignees
@tphinney @servantb
Labels
enhancement New feature or request

Comments

@tphinney
Copy link
Collaborator

tphinney commented Oct 31, 2019 •
edited
Loading

Currently, the small caps inherit the spacing (by reference, in FL file) from the caps.
This is might be a bit too loose.

NOTE: If we do adjust the small cap spacing, be sure to note effect on small cap L (l.smcp) sidebearings and in which masters, because we will need to revisit #178 /periodcentered.loclCAT.smcp and ALSO /ldot.smcp
@tphinney tphinney added the bug Something isn't working label Oct 31, 2019
@tphinney
Copy link
Collaborator Author

tphinney commented Nov 1, 2019

Huh. Started looking at it today in actual testing, and surprisingly ... looks ok at least in some masters? Needs more testing.

@tphinney tphinney changed the title small cap spacing probably too loose small cap spacing maybe too loose? Nov 1, 2019
@tphinney tphinney added enhancement New feature or request and removed bug Something isn't working labels Nov 3, 2019
@tphinney tphinney mentioned this issue Nov 3, 2019
Closed
@servantb
Copy link
Collaborator

Small caps spacing looks good except for the condensed masters (although :CndCtr and :BlkCndCtr are okay). In those masters it's too tight.

@tphinney
Copy link
Collaborator Author

Delayed briefly because of a FontLab issue, but it was resolved. We could tackle this now. As it is small caps, it does not have to be completed right away for Google, but would still be good to finish up.

@tphinney tphinney self-assigned this Nov 24, 2019
@tphinney tphinney changed the title small cap spacing maybe too loose? small cap spacing too loose or tight? Nov 25, 2019
@tphinney tphinney changed the title small cap spacing too loose or tight? small cap spacing: could be looser in some :CndEtc masters? Dec 1, 2019
@tphinney
Copy link
Collaborator Author

tphinney commented Dec 5, 2019

#218 needs to be fixed before we tackle this

@tphinney
Copy link
Collaborator Author

tphinney commented Dec 12, 2019 •
edited
Loading

The other issue #218 is resolved. @servantb and I should now take a look at this, when he has time.

@tphinney tphinney moved this to To do in Science Gothic VF Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tphinney tphinney

@servantb servantb

Labels
enhancement New feature or request
Projects
Science Gothic VF
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tphinney @servantb