Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_category and metadata_vs_api are very similar #858

Open
simoncozens opened this issue Mar 18, 2024 · 1 comment
Open

check_category and metadata_vs_api are very similar #858

simoncozens opened this issue Mar 18, 2024 · 1 comment
Milestone

Comments

@simoncozens
Copy link
Contributor

For both of them:

description = (
    "This script compares the info on local METADATA.pb files"
    " with data fetched from the Google Fonts Developer API.\n\n"
    " In order to use it you need to provide an API key."
)

and there's a lot of common code. We need to choose one and kill the other. metadata_vs_api looks more complete.

@simoncozens simoncozens added this to the 1.0.0 milestone Mar 18, 2024
@m4rc1e
Copy link
Collaborator

m4rc1e commented Apr 9, 2024

I'd say kill both. I've personally never used these tools. The backend team's fork of gftools has diverged so much I think we'll be able to do this without upsetting anyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants