Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical Metrics definition #4

Open
vv-monsalve opened this issue Apr 27, 2021 · 4 comments
Open

Vertical Metrics definition #4

vv-monsalve opened this issue Apr 27, 2021 · 4 comments

Comments

@vv-monsalve
Copy link
Contributor

vv-monsalve commented Apr 27, 2021 •
edited
Loading

The original values for Vertical Metrics in the font significantly differed among sTypo, hhea and Win metrics (images below). The line-height in Safari was too short while in Windows was too tall.

Screen Shot 2021-04-27 at 11 45 36

OS X High Sierra Safari_11
Desktop_OS_X_High_Sierra_safari_11 1_
Windows 10 Chrome_71
Desktop_Windows_10_chrome_71 0_
@vv-monsalve
Copy link
Contributor Author

vv-monsalve commented Apr 27, 2021 •
edited
Loading

To solve it, following our vertical metrics schema, new values were assigned to seek a balance that would perform more evenly in all platforms.

OS X High Sierra Safari_11
Desktop_OS_X_High_Sierra_safari_11 1_
Windows 10 Chrome_71
Desktop_Windows_10_chrome_71 0_

@vv-monsalve
Copy link
Contributor Author

vv-monsalve commented Apr 27, 2021 •
edited
Loading

Before & after comparison images

OS X High Sierra Safari_11
Desktop_OS_X_High_Sierra_safari_11 1_
Windows 10 Chrome_71
Desktop_Windows_10_chrome_71 0_

@davelab6
Copy link
Member

Great!

@vv-monsalve
Copy link
Contributor Author

After reviewing this further, given the nature of the project, a slightly generous line-height was chosen.

OS X High Sierra Safari_11
Desktop_OS_X_High_Sierra_safari_11 1_
Windows 10 Chrome_71
Desktop_Windows_10_chrome_71 0_
Windows 10 Edge_18
Desktop_Windows_10_edge_18 0_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davelab6 @vv-monsalve