Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform-module readme updater does not replace git-styled refs #2416

Open
d-costa opened this issue Oct 30, 2024 · 0 comments
Open

terraform-module readme updater does not replace git-styled refs #2416

d-costa opened this issue Oct 30, 2024 · 0 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@d-costa
Copy link

d-costa commented Oct 30, 2024

Is your feature request related to a problem? Please describe.

terraform-module release type does not replace version in READMEs that use git-styled references:

module "vpc" {
  source = "git::https://example.com/vpc.git?ref=v1.2.0"
}

Describe the solution you'd like

  • Add the ability for the README updater to replace such versions, for example:
ref=v[\d]+.[\d]+.[\d]+
ref=v${this.version.major}.${this.version.minor}.${this.version.patch}

Describe alternatives you've considered

  • Run a workflow on release please PRs to add a commit replacing all ref=[\d]+.[\d]+.[\d]+ occurrences.

Additional context

  • Our team has some GitHub repositories with multiple modules. Would it be possible to run the updater recursively?

Example structure:

  • module-a
    • main.tf
    • README.md
  • module-b
    • main.tf
    • outputs.tf
    • README.md
@d-costa d-costa added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants