Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dart pubspec updater doesn't work as expected for prerelease. #2400

Open
ronnnnn opened this issue Oct 11, 2024 · 0 comments · May be fixed by #2406
Open

Dart pubspec updater doesn't work as expected for prerelease. #2400

ronnnnn opened this issue Oct 11, 2024 · 0 comments · May be fixed by #2406
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@ronnnnn
Copy link

ronnnnn commented Oct 11, 2024 •
edited
Loading

Overview

In case of defining a version with prerelease version and without build number in pubspec.yaml, dart pubspec updater updates the version with build number.

Expected

The version should be updated prerelease version and build number.

Actual

Dart pubspec updater recognizes prerelease version as build number.
https://github.com/googleapis/release-please/blob/64ffba96734bf158818121c067870077d903611b/src/updaters/dart/pubspec-yaml.ts#L29C39-L29C66

You can confirm this behavior from this PR.

Environment details

Steps to reproduce

  1. Define version with prerelease version (like version: 1.0.0-dev01) on pubspec.yaml.
  2. run googleapis/release-please-action on GitHub Actions.
@ronnnnn ronnnnn added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 11, 2024
@ronnnnn ronnnnn linked a pull request Oct 16, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: dart pubspec updater with prerelease ronnnnn/release-please
2 participants
@chingor13 @ronnnnn