Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent version of Expo do not require config settings in app.json, app.config.js to be in expo property #2395

Open
andokai opened this issue Oct 3, 2024 · 0 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@andokai
Copy link

andokai commented Oct 3, 2024

Environment details

  • OS: macOS 15
  • Node.js version: 22
  • npm version: 10
  • release-please version: 4

Steps to reproduce

  1. Create an Expo project
  2. Ensure that the app.json is in the newer format i.e.
{
  "version": "1.0.0"
}

and not the old format

{
  "expo": {
    "version": "1.0.0"
  }
}
  1. Run release please and you'll notice a crash as it's looking for version in a property that doesn't exist.
    updateContent(content: string, logger: Logger = defaultLogger): string {

Details here https://github.com/expo/fyi/blob/main/root-expo-object.md

@andokai andokai added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants