Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the version / tag that will be generated in the PR json #2341

Open
stecullum opened this issue Jul 23, 2024 · 0 comments
Open

Expose the version / tag that will be generated in the PR json #2341

stecullum opened this issue Jul 23, 2024 · 0 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@stecullum
Copy link

Can you consider outputting the release version info that the PR will create in the pr json.

This opens up the opportunity to do any kind of extra file manipulation.. for example...

In a github action.. We can update the PR files with any additional infor we want for example...

   - uses: googleapis/release-please-action@v4
      id: release
      with:
        token: "${{ secrets.GITHUB_TOKEN }}"
        config-file: release-please-config.json
        manifest-file: .release-please-manifest.json

  ## we have just created a PR now modify it however we want eg.. replace the image tag in a k8s manifest
  - name: Modify pull-request files after RP
    if: steps.release.outputs.prs_created == 'true'. 
    uses: jaywcjlove/github-action-modify-file-content@main
    with:
      branch: ${{ fromJson(steps.release.outputs.pr).headBranchName }}
      body: "{{ fromJson(steps.release.outputs.pr).version }} .. **I didnt see it in json**
      path: 'deployment.yaml'

Thanks

@stecullum stecullum added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants