Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared base implementation for ZetaSQL to be used by Spanner, BigQuery, Apache Beam SQL? #189

Closed
tswast opened this issue Jun 15, 2021 · 2 comments
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. type: process A process-related concern. May include testing, release, or the like.

Comments

@tswast
Copy link
Collaborator

tswast commented Jun 15, 2021

Discussing the possibility of using this package from Ibis (ibis-project/ibis-bigquery#72), I realized it may be helpful to share code between BigQuery and Spanner (and other Zeta SQL dialects) in the SQLAlchemy connectors, similar to what we've done (but haven't completed) with the Ibis connectors.

CC @larkee -- I recall you mentioned there was work being done on a SQLAlchemy connector for Spanner? Perhaps we can collaborate on a shared ZetaSQL SQLAlchemy base implementation?

@tswast tswast added the type: process A process-related concern. May include testing, release, or the like. label Jun 15, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Jun 15, 2021
@tswast
Copy link
Collaborator Author

tswast commented Jun 15, 2021

https://github.com/cloudspannerecosystem/python-spanner-sqlalchemy -> https://github.com/googleapis/python-spanner-sqlalchemy?

I'm not sure if it's even possible to make something useful in SQLAlchemy without connecting to a real data system, but it's worth investigating.

@tswast
Copy link
Collaborator Author

tswast commented Jun 9, 2023

I learned a bit more about the Spanner connector since I filed this issue. They made some choices in their DB-API where the types of the values returned are different from what we do in BigQuery (and from what is expected by pandas). It'd be a breaking change for them to change at this point, so I'll close as infeasible.

@tswast tswast closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

1 participant