Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: deprecate the current default user-agent string. #820

Open
2 tasks
chalmerlowe opened this issue Oct 11, 2024 · 1 comment
Open
2 tasks

Chore: deprecate the current default user-agent string. #820

chalmerlowe opened this issue Oct 11, 2024 · 1 comment
Assignees
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API.

Comments

@chalmerlowe
Copy link
Collaborator

The default user-agent issued by this module is not in accordance with RFC 9110 which recommends: product/major.minor.micro (ie. pandas/2.0.1).

Current style: product-x.y.z (pandas-2.0.1)

Note: in the docstring for user_agent in the Google api-core ClientInfo class, the api-core folks recommend but do not require the use of the format the rfc suggests (with the forward slash):

user_agent (Optional[str]): Prefix to the user agent header. This is
            used to supply information such as application name or partner tool.
            Recommended format: ``application-or-tool-ID/major.minor.version``.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Oct 11, 2024
@mrfaizal mrfaizal assigned chalmerlowe and unassigned whuffman36 Oct 21, 2024
@tswast
Copy link
Collaborator

tswast commented Nov 12, 2024

Note: when doing so, make sure to update internal concord pipelines to accept either - or / as the version separator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API.
Projects
None yet
Development

No branches or pull requests

3 participants