Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCUSSION: policy for dependency updates that aren't covered by NEP 29 #357

Open
tswast opened this issue Mar 29, 2021 · 2 comments
Open
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. type: process A process-related concern. May include testing, release, or the like.

Comments

@tswast
Copy link
Collaborator

tswast commented Mar 29, 2021

NEP 29, which the pandas community has also been following, has a timeline for Python and NumPy supported versions.

It does not have related recommendations for pandas and certainly not other packages we depend on such as google-cloud-bigquery, google-cloud-bigquery-storage, pydata-google-auth, google-cloud-core, google-api-core, google-auth, google-auth-oauthlib.

If I interpret the NumPy algorithm correctly, we need to support a two-year window.

all minor versions of package-name released in the prior 24 months from the anticipated release date with a minimum of 3 minor versions of package-name

We're actually just about caught up with that in the google-cloud-bigquery dependency.

Our minimum version is 1.11.x, which was released in April 2019. https://github.com/googleapis/python-bigquery/blob/master/CHANGELOG.md#1110 We'd be able to start incrementing minimum version to 1.12.0 in May.

Thoughts? Is 2 years the right window?

@tswast
Copy link
Collaborator Author

tswast commented Mar 29, 2021

Oh, and re: pandas, it looks like we're about there too. We require pandas>=0.23.2, which means if we did a release today I think we could bump the minimum version to 0.24.2, as it was released in March 2019 and we'd be support >= 3 minor versions (0.24.x, 0.25.x, 1.0.x, 1.1.x, and 1.2.x).

@max-sixty
Copy link
Contributor

Yes, we did something similar in xarray: http://xarray.pydata.org/en/stable/installing.html#minimum-dependency-versions

We also have a tool for getting the relevant version of dependencies, which may be useful if there's a number of them

@tswast tswast added the type: process A process-related concern. May include testing, release, or the like. label Jul 16, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

2 participants