-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Errno::ECONNRESET
to retriable network errors
#18902
Comments
@dazuma @bajajneha27 @NivedhaSenthil @SandeepTuniki Would you see any reason why |
I think this makes sense, and is in line with the Storage error strategy currently being worked on internally. We should add it here: https://github.com/googleapis/google-api-ruby-client/blob/main/google-apis-core/lib/google/apis/core/http_command.rb#L295 |
Thank you @dazuma for your feedback on this issue. |
Would it make sense to also include
Errno::ECONNRESET
(broken network connections) inRETRIABLE_ERRORS
?(via
Google::Apis::TransmissionError
- same likeECONNREFUSED
andETIMEDOUT
in #10026)I've hit that recently in context of GCS file downloads on Windows Server 2019 Datacenter 10.0.17763, Ruby 3.0.4p208 (2022-04-12 revision 3fa771dded) [x64-mingw32] and
google-apis-core
0.9.3.The text was updated successfully, but these errors were encountered: