Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing dependencies #1804

Merged
merged 5 commits into from
Oct 16, 2023
Merged

fix: add missing dependencies #1804

merged 5 commits into from
Oct 16, 2023

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 16, 2023

This PRs adds the necessary dependencies for generating google-cloud-asset. See setup.py here: https://github.com/googleapis/python-asset/blob/7c1f5fec48364889da95d21042278a9d944688c4/setup.py#L41-L43

@parthea parthea requested a review from a team as a code owner October 16, 2023 15:40
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 16, 2023
This was referenced Oct 16, 2023
Merged
Merged
@parthea parthea enabled auto-merge (squash) October 16, 2023 16:14
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 16, 2023
@parthea
Copy link
Contributor Author

parthea commented Oct 16, 2023

The current failure is from mypy

nox > mypy --explicit-package-bases google
google/cloud/asset_v1/types/assets.py:266: error: Variable "google.cloud.orgpolicy.v1.orgpolicy_pb2.Policy" is not valid as a type  [valid-type]
google/cloud/asset_v1/types/assets.py:266: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases

@parthea
Copy link
Contributor Author

parthea commented Oct 16, 2023

I removed google-cloud-org-policy which caused mypy to fail. I'll create a separate PR once I get mypy to pass.

@parthea parthea merged commit 3e020cd into main Oct 16, 2023
53 checks passed
@parthea parthea deleted the add-dependencies branch October 16, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohmayr ohmayr ohmayr approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthea @ohmayr