-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add deprecation comments for message fields and enums #1738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
force-pushed
the
add-deprecation-note-for-enums-and-messages
branch
2 times, most recently
from
August 11, 2023 17:51
6dfb799
to
b618b4b
Compare
parthea
force-pushed
the
add-deprecation-note-for-enums-and-messages
branch
from
August 11, 2023 18:01
b618b4b
to
12402ca
Compare
parthea
force-pushed
the
add-deprecation-note-for-enums-and-messages
branch
from
August 11, 2023 18:02
12402ca
to
6328a95
Compare
parthea
changed the title
docs: add deprecation comments for enums and message
docs: add deprecation comments for messages and enums
Aug 11, 2023
parthea
changed the title
docs: add deprecation comments for messages and enums
docs: add deprecation comments for message fields and enums
Aug 11, 2023
I tested the changes locally by regenerating the python client for
|
dizcology
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1733 🦕
This PR is on hold until the client library AIPs are updated: https://google.aip.dev/client-libraries/4210 . Also see aip-dev/google.aip.dev#1198