Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove duplicate import statement for google.longrunning.operations_pb2 #1726

Merged
merged 18 commits into from
Aug 23, 2023
Merged

fix: remove duplicate import statement for google.longrunning.operations_pb2 #1726

merged 18 commits into from
Aug 23, 2023

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Aug 9, 2023 •
edited
Loading

Fixes #1727 🦕

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Aug 9, 2023
@parthea parthea changed the title test: update version of googleapis/googleapis used for goldens fix: remove duplicate import statement for google.longrunning.operations_pb2 Aug 9, 2023
This was referenced Aug 9, 2023
Open
Closed
Closed
@parthea parthea marked this pull request as ready for review August 9, 2023 20:54
@parthea parthea requested a review from a team as a code owner August 9, 2023 20:54
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2023
@parthea parthea requested a review from ohmayr August 9, 2023 20:57
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Aug 10, 2023
vchudnov-g
vchudnov-g approved these changes Aug 23, 2023
View reviewed changes
gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/transports/base.py.j2
@@ -18,9 +18,14 @@ from google.auth import credentials as ga_credentials # type: ignore
from google.oauth2 import service_account # type: ignore

{% filter sort_lines %}
{% set import_ns = namespace(has_operations_mixin=false) %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this may need to be generalized to the other mixins. WDYT?

I don't think we should block on that, but I would add a TODO in the code and reference this PR.

@vchudnov-g vchudnov-g added the automerge Merge the pull request once unit tests and other checks pass. label Aug 23, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit e3f08cd into main Aug 23, 2023
53 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the update-googleapis-2 branch August 23, 2023 19:48
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 23, 2023
@release-please release-please bot mentioned this pull request Aug 23, 2023
Merged
@vchudnov-g vchudnov-g mentioned this pull request Aug 23, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchudnov-g vchudnov-g vchudnov-g approved these changes

@ohmayr ohmayr Awaiting requested review from ohmayr

Assignees

@vchudnov-g vchudnov-g

@ohmayr ohmayr

Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate import statement for google.longrunning.operations_pb2 in python-logging
3 participants
@parthea @vchudnov-g @ohmayr