Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version of googleapis/googleapis in repositories.bzl #1729

Closed
parthea opened this issue Aug 9, 2023 · 0 comments · Fixed by #1736
Closed

Update the version of googleapis/googleapis in repositories.bzl #1729

parthea opened this issue Aug 9, 2023 · 0 comments · Fixed by #1736
Assignees

Comments

@parthea
Copy link
Contributor

parthea commented Aug 9, 2023

The version of googleapis/googleapis in repositories.bzl should be updated periodically to a newer version in order for the golden files to be kept up to date.

_maybe(
http_archive,
name = "com_google_googleapis",
strip_prefix = "googleapis-ffc531383747ebb702dad3db237ef5fdea796363",
urls = ["https://github.com/googleapis/googleapis/archive/ffc531383747ebb702dad3db237ef5fdea796363.zip"],
)

In googleapis/python-logging#746, there is an issue where an import statement is duplicated. I was only able to re-create the issue in 5e03e71 using the latest version of googleapis/googleapis . #1726 fixes the problem with the duplicate import. I had to back out the update of googleapis/googleapis in #1726 because it caused a large change to the golden files. The update of googleapis/googleapis should be done in a separate PR. Creating this issue to track updating googleapis/googleapis in repositories.bzl once #1726 is fixed.

import warnings
from typing import Callable, Dict, Optional, Sequence, Tuple, Union
from google.api_core import grpc_helpers
from google.api_core import gapic_v1
import google.auth # type: ignore
from google.auth import credentials as ga_credentials # type: ignore
from google.auth.transport.grpc import SslCredentials # type: ignore
import grpc # type: ignore
from google.cloud.logging_v2.types import logging_config
from google.protobuf import empty_pb2 # type: ignore
from .base import ConfigServiceV2Transport, DEFAULT_CLIENT_INFO

@parthea parthea assigned parthea and ohmayr and unassigned parthea Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants