Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add folder parameter #833

Open
borisdamevin opened this issue Aug 22, 2023 · 3 comments
Open

Add folder parameter #833

borisdamevin opened this issue Aug 22, 2023 · 3 comments

Comments

@borisdamevin
Copy link

borisdamevin commented Aug 22, 2023

Is't possibile to add folder parameter? Can be usefull with specific monorepo structure.

Example:

"bundle": {
  "command": "npm install",
  "folder": "packages/repo-1",
}

Thank by advance.

@justinfagnani
Copy link
Collaborator

What do you want this parameter to do?

@borisdamevin
Copy link
Author

borisdamevin commented Nov 11, 2023

Have sweat configuration when we need to target internal packages.json, to avoid to directly use ``cd packages/repo-1 && npm install` for example.

"bundle": {
  "command": "cd packages/repo-1 && npm install"
}

@deebloo
Copy link

deebloo commented Nov 28, 2023

For that example wouldn't you define the command inside of packages/repo-1?
Then your root bundle config would just be.

"bundle": {
  "dependencies": ["./packages/repo-1:bundle"]
}

Then inside of repo-1

"bundle": {
  "command": "npm i"
}

I think your problem is solved by cross package dependencies. https://github.com/google/wireit#cross-package-dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants