Skip to content
This repository has been archived by the owner on Dec 12, 2021. It is now read-only.

Event.parent_name dropped from incoming santa events #26

Closed
thehesiod opened this issue Oct 25, 2018 · 4 comments
Closed

Event.parent_name dropped from incoming santa events #26

thehesiod opened this issue Oct 25, 2018 · 4 comments

Comments

@thehesiod
Copy link

this key is sent via santa, but is not stored to the events datastore table...this is useful when things are marked as run as root, so we can see if it was called via sudo or not.

@msuozzo
Copy link
Member

msuozzo commented Oct 25, 2018

I think this was another thing we dropped from the schema after we implemented Event deduping (since parent_name didn't have a 1:1 associated with the Event anymore). While I certainly think it's reasonable for you to add it if you need it, I'm not sure Upvote should commit to storing all values sent from Santa. Where do you see this information being surfaced?

@thehesiod
Copy link
Author

parent_name is coming from the events sent via santad via sync...so I'm not sure what you mean it doesn't have a 1:1 association with event. It has the same behavior as event_type, given it means the most recent parent_name a said event occurred with. Given I've described a useful scenario for displaying this information it seems useful no?

@thehesiod
Copy link
Author

enabled here: farmersbusinessnetwork@5cf412f

@thehesiod
Copy link
Author

closing in favor of #24

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants