"Awaiting Votes" view

[alexmac]

The main "blockables" view would be easier to use if we could either sort based on the status or have a separate "Awaiting Votes" view to see what apps/certs still need to be investigated

[thehesiod]

so it seems like the State column can now accomplish this. I'll just need a Search option for it. I'll see if I can do it if no-one gets to it.

[thehesiod]

hah, actually, there's a bug, @chief8192 looks like the state column does not recurse into the certificate for each binary to check to see if the certificate is whitelisted.

[thehesiod]

and it looks like it's supposed to per https://github.com/google/upvote/blob/master/upvote/gae/modules/upvote_app/frontend/web_ui/components/statechip/statechip-filter.js#L53

  // If the binary has no blockable-specific rules but does have cert-specific
  // rules, display the cert's state.

from what I see, the cert param is always null

[chief8192]

I'll take a look

[thehesiod]

so I looked a bit into this, and it seems it's not as simple as I thought. "Awaiting Votes" is dynamically calculated in the client side javascript, which means you can't search/filter by it through the existing search mechanism.

[thehesiod]

hmm, so the plot thickens.

On: https://[APP_ID].appspot.com/blockables/[SHA256] it does show the right state for certificate being whitelisted: Whitelisted Publisher

However on https://[APP_ID].appspot.com/admin/blockables/[SHA256], it lists it as untrusted, similarly onhttps://[APP_ID].appspot.com/admin/blockables

so it seems the web_ui code needs to be used by the admin_ui code. However, this still means that you can't filter by "state" easily. I suppose the client can do multiple page requests until it has enough data by filtering on the client side...however that seems to kinda break the model.

[thehesiod]

so I've added the ability to view cert fallbacks on the admin blockables page here: farmersbusinessnetwork@3490ba3 this gets us half way there as it will now show the correct state if the cert has been whitelisted. I did not add the "vote" info, not sure if it's needed? What's missing now is being able to filter/sort by the state. Perhaps we can get away with using the events page if we sort by ALLOW/BLOCK UNKNOWN...however then it would be nice being able to group by the file name, or something to collapse similar issues. I'll discuss with @alexmac

[thehesiod]

I think we're now good with what we've done in our branch, @alexmac want to close this in lieu of #24?