Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass secrets via flags #662

Open
mhutchinson opened this issue Jul 1, 2022 · 0 comments
Open

Don't pass secrets via flags #662

mhutchinson opened this issue Jul 1, 2022 · 0 comments
Assignees
@mhutchinson
Labels
enhancement New feature or request

Comments

@mhutchinson
Copy link
Contributor

Looking at witness/golang/omniwitness/monolith/monolith.go, we realized that it takes the private key material via flags. This is a security risk as anyone on the same machine could get this via ps.

We should swap this over to use env variables or a file, or something. And also review other main files to make sure there aren't others like this.
@mhutchinson mhutchinson added the enhancement New feature or request label Jul 1, 2022
@mhutchinson mhutchinson self-assigned this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhutchinson mhutchinson

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhutchinson