-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Windows event logs messages attributes #2910
Extract Windows event logs messages attributes #2910
Conversation
fwiw, I think once this is in, it could mean we can make a lot of those field mappings better in https://github.com/google/timesketch/blob/master/data/sigma_config.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this feature. Looking forward to the great possibilities we will get with the mapping.
Please see the comments below. If you have questions regarding the multi analyzer approach, let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second round:
This works really well already! Main comments are around wording of errors and checking required dict entries.
What are your plans for moving the existing feature_extraction.py
into the plugin system?
If you are fine with it, I would like to test both changes together, so either merge it in one PR or in two dependent PRs.
Co-authored-by: Janosch <[email protected]>
Co-authored-by: Janosch <[email protected]>
Co-authored-by: Janosch <[email protected]>
Co-authored-by: Janosch <[email protected]>
Co-authored-by: Janosch <[email protected]>
Co-authored-by: Janosch <[email protected]>
Co-authored-by: Janosch <[email protected]>
Co-authored-by: Janosch <[email protected]>
Co-authored-by: Janosch <[email protected]>
Co-authored-by: Janosch <[email protected]>
Co-authored-by: Janosch <[email protected]>
Co-authored-by: Janosch <[email protected]>
Co-authored-by: Janosch <[email protected]>
Co-authored-by: Janosch <[email protected]>
Co-authored-by: Janosch <[email protected]>
Co-authored-by: Janosch <[email protected]>
Co-authored-by: Janosch <[email protected]>
Co-authored-by: Janosch <[email protected]>
Notes from offline sync:
|
Windows event log contains details about the event in the message field (EventData XML attribute). Extracting the information in the EventData would enable analysts to query/filter event logs based on the attributes in EventData.
The figure below shows the high-level schema.
Plaso extracts the fields and stores the values as a list in the field
strings
.This PR maps the extracted event log
strings
to the respective attributes usingwinevt.yaml
(data/winevt.yaml`)Checks
Closing issues
Put
closes #2911
in your comment to auto-close the issue that your PR fixes(if such).