use executor-agnostic timers #298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Things have been a bit crazy here but I'll try to get a review done this weekend. |
|
A better solution would be to generalize the timer behaviour, but doing that would be non-trivial. |
LucioFranco
reviewed
Mar 27, 2020
| @@ -28,6 +28,7 @@ travis-ci = { repository = "google/tarpc" } | |||
| [dependencies] | |||
| fnv = "1.0" | |||
| futures = "0.3" | |||
| futures-timer = "3.0" | |||
There was a problem hiding this comment.
We've seen some issues come from this crate in the past just FYI. I would advise against using it.
|
Yeah, I don't think that futures-timer is a desirable solution. Thanks for the effort though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the tokio Timeout with a pure futures-based approach: race the request with a delay from the
futures-timercrate.I haven't extensively tested this, but for my minimal use case it seems to work.
Supersedes #296 and fixes #297